Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the mobile view of GitOps page #5726

Closed
wants to merge 3 commits into from

Conversation

Harsh-svg988
Copy link
Contributor

Description

This PR fixes # 5690

Notes for Reviewers
Initially "What is GitOps?" was overlapping first section of the page but now it is separated which enhances the overall view of the mobile user.
Screenshot 2024-07-25 at 11 46 29 PM

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Jul 25, 2024

🚀 Preview for commit e9056fc at: https://66a29a431f04b59759cc933b--layer5.netlify.app

@Ashparshp
Copy link
Contributor

Ashparshp commented Jul 26, 2024

This PR fixes #5690 @Harsh-svg988 Make sure not to have a space, otherwise it will not link with the issue and we will miss it.

Copy link
Contributor

@Ashparshp Ashparshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue still persists between 443px and 639px.

@Harsh-svg988
Copy link
Contributor Author

I will look into it

@Ashparshp
Copy link
Contributor

@Harsh-svg988 Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

@Ashparshp
Copy link
Contributor

@Harsh-svg988 Any luck?

@Ashparshp
Copy link
Contributor

@Harsh-svg988 Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

@sudhanshutech
Copy link
Member

@Harsh-svg988 are you taking care of feedback?

@l5io
Copy link
Contributor

l5io commented Aug 6, 2024

🚀 Preview for commit d985163 at: https://66b2294f78477a113d982b51--layer5.netlify.app

@hargunkaur286
Copy link
Member

hargunkaur286 commented Aug 8, 2024

@Harsh-svg988 Thank you for your contribution. It solves the issue for mobile screens, but now we have a lot of empty space in between the sections for the desktop screens

Screenshot 2024-08-08 at 2 16 31 PM

@Ashparshp
Copy link
Contributor

@Harsh-svg988, any updates on this? Or are you no longer up for this issue, as we haven't heard back in a while?

@Ashparshp
Copy link
Contributor

@Harsh-svg988, last ask, if you're availble?

@Ashparshp
Copy link
Contributor

@Harsh-svg988, as we haven't heard back from you, I'll be closing this by PR by Monday and move to someone else.

@Ashparshp
Copy link
Contributor

Closing the PR as we haven't heard back... Thank you @Harsh-svg988..

A new PR has been raised for this issue.

@Ashparshp Ashparshp closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants